8368933: [lworld] Unsafe.arrayBaseOffset() ambiguous

[fparain]

Renaming of Unsafe methods to prevent ambiguity when null is passed in argument.

Tested with Mach5 tier1-3.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8368933: [lworld] Unsafe.arrayBaseOffset() ambiguous (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1684/head:pull/1684
$ git checkout pull/1684

Update a local copy of the PR:
$ git checkout pull/1684
$ git pull https://git.openjdk.org/valhalla.git pull/1684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1684

View PR using the GUI difftool:
$ git pr show -t 1684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1684.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368933: [lworld] Unsafe.arrayBaseOffset() ambiguous

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (5ce9aaa6)

[liach]

Another way could be that we update AddressComputationContractTest to cast null to Class. That test should be updated to cover the new instance-based offset/scale methods too.

[fparain]

Thank you for the review Chen!

[fparain]

/integrate

[openjdk]

Going to push as commit 8845b6a.
Since your change was applied there have been 134 commits pushed to the lworld branch:

• 66c0082: Merge jdk
• 2aafda1: 8366948: AOT cache creation crashes when iterating training data
• a2870d6: 8368015: Shenandoah: fix error in computation of average allocation rate
• ... and 131 more: https://git.openjdk.org/valhalla/compare/cccb5014b5f84f8cd57ff808f5bbc07263e25545...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain Pushed as commit 8845b6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.