-
Notifications
You must be signed in to change notification settings - Fork 126
Adding flattening of strict final fields #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lworld
Are you sure you want to change the base?
Conversation
👋 Welcome back fparain! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This would forbid the class which contains the
This is equally valid to null-restricted field of non- |
@fparain This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
/keepalive |
@fparain The pull request is being re-evaluated and the inactivity timeout has been reset. |
@fparain this pull request can not be integrated into git checkout flat_final
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
@fparain This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
Strict final instance fields are not subject to concurrent writes during a read access, so they can be flattened even if they are nullable and bigger than 64 bits. The NULLABLE_NON_ATOMIC_FLAT layout is added for this particular case.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1407/head:pull/1407
$ git checkout pull/1407
Update a local copy of the PR:
$ git checkout pull/1407
$ git pull https://git.openjdk.org/valhalla.git pull/1407/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1407
View PR using the GUI difftool:
$ git pr show -t 1407
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1407.diff