Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site #610

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Nov 16, 2024

Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on Eclipse 2024-06 and 2024-09. It is not breaking Eclipse Icons and about dialog.

JMC 9.0.0 can be installed on Eclipse 2024-06, but as @cimi, mentioned in JIRA issue that Eclipse branding breaks, including the actual Eclipse application icon and the about dialog.

For the newer version of eclipse verification can be done after the release.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/610/head:pull/610
$ git checkout pull/610

Update a local copy of the PR:
$ git checkout pull/610
$ git pull https://git.openjdk.org/jmc.git pull/610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 610

View PR using the GUI difftool:
$ git pr show -t 610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/610.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2024

👋 Welcome back vpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Nov 16, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant