Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261: Use test flag to skip JDP multicast tests in JolokiaTest #588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Sep 11, 2024

I just became aware that there is a new flag used to skip JDP tests.
I previously added some env checking to skip similar multicast tests for Jolokia.
Hence it would be a lot cleaner to use the new standardized mechanism for this.
Trying out whether this fixes JMC-8261


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8261: Use test flag to skip JDP multicast tests in JolokiaTest (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/588/head:pull/588
$ git checkout pull/588

Update a local copy of the PR:
$ git checkout pull/588
$ git pull https://git.openjdk.org/jmc.git pull/588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 588

View PR using the GUI difftool:
$ git pr show -t 588

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/588.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@skarsaune This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261: Use test flag to skip JDP multicast tests in JolokiaTest

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@aptmac
Copy link
Member

aptmac commented Sep 16, 2024

@skarsaune Here's a jira issue you can use for this PR, and then Skara should pick it up and run the CI. It looks like after the change to use the setup-maven action in the workflow (link) we cannot run CI in our forks.

For example, the action that tried to run on your fork here shows an error:
stcarolas/[email protected] is not allowed to be used in skarsaune/jmc. Actions in this workflow must be: within a repository owned by skarsaune, created by GitHub, verified in the GitHub Marketplace, or matching the following: openjdk/jmc.

@skarsaune skarsaune changed the title Try to use new test flag to decide whether multicast is supported JMC-8261: Try to use new test flag to decide whether multicast is supported Sep 18, 2024
@openjdk openjdk bot added the rfr label Sep 18, 2024
@skarsaune skarsaune changed the title JMC-8261: Try to use new test flag to decide whether multicast is supported JMC-8261: Use test flag to skip JDP multicast tests in JolokiaTest Sep 18, 2024
@openjdk openjdk bot changed the title JMC-8261: Use test flag to skip JDP multicast tests in JolokiaTest 8261: Use test flag to skip JDP multicast tests in JolokiaTest Sep 18, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2024

Webrevs

@skarsaune
Copy link
Contributor Author

skarsaune commented Sep 19, 2024

@aptmac : even after referencing the issue. it still does not appear to run the ci tests on the pr. Any way to trigger it? As the pr is speculative, it does not make sense to merge it before we have tested it.

@aptmac
Copy link
Member

aptmac commented Sep 19, 2024

I'm not sure what's happening here, will have to take a look at why the rest of the checks haven't triggered.

@aptmac
Copy link
Member

aptmac commented Sep 26, 2024

I took a bit more of a look around some of our forks, and I'm not seeing the issue I posted in the comment above: #588 (comment).

I'm curious what happens if you manually trigger a workflow on the master branch at: https://github.com/skarsaune/jmc/actions

I'm wondering if it's a mis-configuration of the workflow actions in your fork somehow.

@aptmac aptmac mentioned this pull request Oct 24, 2024
2 tasks
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2024

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@aptmac
Copy link
Member

aptmac commented Oct 25, 2024

I took this branch and ran the actions on my own fork, there's a style issue that needs to be fixed by running mvn spotless:apply, but the fix for Mac doesn't seem to be working as intended:

https://github.com/aptmac/jmc/actions/runs/11522768181/job/32079324937#step:9:16964

@skarsaune
Copy link
Contributor Author

Thanks. Mac OS was the particular case that fails. It may be something else then. As I have no simple way to reproduce the pipeline behaviour I suggest we abandon this one. Bigger fish to fry.

@openjdk openjdk bot added the ready label Oct 30, 2024
@skarsaune
Copy link
Contributor Author

Hmm, since there seems to be problems with multicast on Mac OS in the pipeline, I assumed that the flag to avoid JDP multicast tests was set in the pipeline, but I assume that that is not the case 🤔

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2024

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants