8373038: Interpolator factories should follow method naming convention

[mstr2]

The following interpolator factories don't follow the standard method naming convention:

• Interpolator.SPLINE(double, double, double, double)
• Interpolator.TANGENT(Duration, double, Duration, double)
• Interpolator.TANGENT(Duration, double)
• Interpolator.STEPS(int, StepPosition)

New methods named ofSpline, ofTangent, and ofSteps are added. The existing methods are deprecated (not for removal) in favor of the correctly-named methods. This change is in line with the new ofLinear method added with #1977.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request matching fixVersion jfx26 to be approved (needs to be created)
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8373038: Interpolator factories should follow method naming convention (Enhancement - P4)

Reviewers

• Andy Goryachev (@andy-goryachev-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1996/head:pull/1996
$ git checkout pull/1996

Update a local copy of the PR:
$ git checkout pull/1996
$ git pull https://git.openjdk.org/jfx.git pull/1996/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1996

View PR using the GUI difftool:
$ git pr show -t 1996

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1996.diff

Using Webrev

Link to Webrev Comment

[mstr2]

/reviewers 2
/csr

[bridgekeeper]

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[openjdk]

@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mstr2 please create a CSR request for issue JDK-8373038 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[mlbridge]

Webrevs

• 00: Full (1fb91b9a)

[andy-goryachev-oracle]

This change makes sense from purely esthetic reasons, though it probably won't be noticed by the app developers as they mostly deal with the interpolators via CSS (and there is no change there, as far as I can tell).

[andy-goryachev-oracle]

lgtm

[andy-goryachev-oracle]

maybe something like "This poorly named method is deprecated in favor of ..." or words to that extent?

or keep the original description?

[andy-goryachev-oracle]

Off-topic: shouldn't this interpolator be specified by the stylesheet (i.e. to be able to modify the transition if needed)?

More of a question for @kevinrushforth