-
Notifications
You must be signed in to change notification settings - Fork 547
Proof of concept drawing context for WritableImage #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hjohn
wants to merge
1
commit into
openjdk:master
Choose a base branch
from
hjohn:feature/writable-image-drawing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
modules/javafx.graphics/src/main/java/com/sun/javafx/util/FXCleaner.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package com.sun.javafx.util; | ||
|
|
||
| import java.lang.ref.Cleaner; | ||
| import java.lang.ref.Cleaner.Cleanable; | ||
|
|
||
| /** | ||
| * A module-wide Cleaner utility for registering cleanup actions on objects | ||
| * that become phantom-reachable. This class maintains a single shared | ||
| * {@link Cleaner} instance for the module, avoiding multiple daemon threads. | ||
| * <p> | ||
| * Usage example: | ||
| * <pre> | ||
| * FXCleaner.register(resource, () -> resource.dispose()); | ||
| * </pre> | ||
| */ | ||
| public class FXCleaner { | ||
| private static final Cleaner CLEANER = Cleaner.create(); | ||
|
|
||
| /** | ||
| * Registers a cleanup action to be run when {@code obj} becomes | ||
| * phantom-reachable. | ||
| * | ||
| * @param obj the object to monitor, cannot be {@code null} | ||
| * @param action the cleanup action to run, cannot be {@code null} | ||
| * @return a {@link Cleanable} that can be used to cancel the cleanup, never {@code null} | ||
| * @throws NullPointerException when any argument is {@code null} | ||
| */ | ||
| public static Cleanable register(Object obj, Runnable action) { | ||
| return CLEANER.register(obj, action); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be no problem to change (an image heavy application still runs absolutely fine), but it is kind of a global change. If there are issues with this, we could make a specific method for writable images to use so we always get an
int[]buffer that the software renderer expects.As it is now, the renderer is writing directly into the underlying image storage, without any copies being made (which is nice and efficient).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious why the byte buffer was chosen initially.
Will
IntBufferbe better on every platform?Also,
w * hmight be negative if the product is greater than ~2B, though it will result in anIllegalArgumentExceptionwith a cryptic "capacity expected to be negative" message.