8348598: Update Libpng to 1.6.47 #729
Open
+3,252
−3,400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport updates bundled libpng to 1.6.47.
There are some differences to jdk11:
libpng.mdin JDK 8, equivalent changes were done toTHIRD_PARTY_READMEUPDATING.txtwere excluded (this file is not present in 8)/lib/Awt2dLibraries.gmkwere excluded, as build system of jdk 8 is different and there is no support forDISABLED_WARNINGS_*thereOtherwise, when it comes to library source files (libpng dir), changes applied cleanly (although they have different path).
I have also tried to use diff to compare contents of libpng directory (after update to 1.6.47) in jdk 8 and jdk 11, there are same, except for
UPDATING.txt, which is only present in jdk 11.Motivation:
fp.h)Testing:
TestCPUAwareness.javaare unrelated)Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/729/head:pull/729$ git checkout pull/729Update a local copy of the PR:
$ git checkout pull/729$ git pull https://git.openjdk.org/jdk8u-dev.git pull/729/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 729View PR using the GUI difftool:
$ git pr show -t 729Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/729.diff
Using Webrev
Link to Webrev Comment