Skip to content

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Sep 6, 2025

ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format, also source files are moved, copyright years updated.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #691 as a prerequisite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347377 needs maintainer approval

Integration blocker

 ⚠️ Dependency #691 must be integrated first

Issue

  • JDK-8347377: Add validation checks for ICC_Profile header fields (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/692/head:pull/692
$ git checkout pull/692

Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 692

View PR using the GUI difftool:
$ git pr show -t 692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/692.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/691 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ed8945a68a67dd51a7cfa332905941afccc12b36 8347377: Add validation checks for ICC_Profile header fields Sep 6, 2025
@openjdk
Copy link

openjdk bot commented Sep 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 6, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2025

Webrevs

@jankratochvil jankratochvil marked this pull request as draft September 7, 2025 20:19
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2025
@jankratochvil jankratochvil force-pushed the 8263622-6986863-8347377 branch from 3076c4f to 9bd2995 Compare September 8, 2025 14:17
@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@jankratochvil this pull request can not be integrated into pr/691 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8263622-6986863-8347377
git fetch https://git.openjdk.org/jdk8u-dev.git pr/691
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/691"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 8, 2025
@jankratochvil jankratochvil marked this pull request as ready for review September 8, 2025 14:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2025
@jankratochvil jankratochvil marked this pull request as draft September 8, 2025 14:20
@openjdk openjdk bot removed merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review labels Sep 8, 2025
@jankratochvil jankratochvil force-pushed the 8263622-6986863-8347377 branch from 9bd2995 to 853ca11 Compare September 9, 2025 08:08
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 9, 2025
@jankratochvil
Copy link
Author

The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1

@jankratochvil jankratochvil marked this pull request as ready for review September 9, 2025 10:38
@openjdk openjdk bot added rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Sep 9, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2025

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant