-
Notifications
You must be signed in to change notification settings - Fork 173
8347377: Add validation checks for ICC_Profile header fields #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/691
Are you sure you want to change the base?
8347377: Add validation checks for ICC_Profile header fields #692
Conversation
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
3076c4f
to
9bd2995
Compare
@jankratochvil this pull request can not be integrated into git checkout 8263622-6986863-8347377
git fetch https://git.openjdk.org/jdk8u-dev.git pr/691
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/691"
git push |
ea13d13
to
322a0c9
Compare
Reviewed-by: prr, jdv
9bd2995
to
853ca11
Compare
322a0c9
to
0fe4334
Compare
The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1 |
@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format, also source files are moved, copyright years updated.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #691 as a prerequisite.
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/692/head:pull/692
$ git checkout pull/692
Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/692/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 692
View PR using the GUI difftool:
$ git pr show -t 692
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/692.diff
Using Webrev
Link to Webrev Comment