-
Notifications
You must be signed in to change notification settings - Fork 159
8278472: Invalid value set to CANDIDATEFORM structure #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
I think the GHA error is a certificate issue and not related to this PR. /approval request Small and trivial fix, low risk. Except for the fix for Copyright year and the path change, original patch applies cleanly. jdk_desktop tests on Windows Server 2022 passed (some tests failed, but they failed before this fix was made) |
@kurashige23 |
Hi all,
This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure
Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u.
This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME.
Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made)
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/648/head:pull/648
$ git checkout pull/648
Update a local copy of the PR:
$ git checkout pull/648
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/648/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 648
View PR using the GUI difftool:
$ git pr show -t 648
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/648.diff
Using Webrev
Link to Webrev Comment