Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237192: Generate stripped/public pdbs on Windows for jdk images #620

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 1, 2025

Hi all,
This is backport JDK-8237192 from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.

File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it's necessary for jdk8u-dev.

Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8237192 needs maintainer approval

Issue

  • JDK-8237192: Generate stripped/public pdbs on Windows for jdk images (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620
$ git checkout pull/620

Update a local copy of the PR:
$ git checkout pull/620
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 620

View PR using the GUI difftool:
$ git pr show -t 620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/620.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 907f9ee7083df384a7433cb933522680e70dcb1f 8237192: Generate stripped/public pdbs on Windows for jdk images Feb 1, 2025
@openjdk
Copy link

openjdk bot commented Feb 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 1, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

keep it open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants