-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8237192: Generate stripped/public pdbs on Windows for jdk images #620
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep it open |
Hi all,
This is backport JDK-8237192 from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.
File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it's necessary for jdk8u-dev.
Change has been verified locally, test-fix only, no risk.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620
$ git checkout pull/620
Update a local copy of the PR:
$ git checkout pull/620
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/620/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 620
View PR using the GUI difftool:
$ git pr show -t 620
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/620.diff
Using Webrev
Link to Webrev Comment