Skip to content

8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/hotspot/gtest/runtime/test_os.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,16 +935,24 @@ TEST_VM(os, dll_address_to_function_and_library_name) {
LOG("shorten_paths=%d, demangle=%d, strip_arguments=%d, provide_scratch_buffer=%d",
shorten_paths, demangle, strip_arguments, provide_scratch_buffer);

// Should show os::min_page_size in libjvm
// Should show Threads::create_vm in libjvm
addr = CAST_FROM_FN_PTR(address, Threads::create_vm);
st.reset();
EXPECT_TRUE(os::print_function_and_library_name(&st, addr,
provide_scratch_buffer ? tmp : nullptr,
sizeof(tmp),
shorten_paths, demangle,
strip_arguments));

#ifdef _WINDOWS
// On Windows, if no full .pdb file is available, the output can be something like "0x... in ..."
if (strncmp(output, "0x", 2) != 0) {
#endif
EXPECT_CONTAINS(output, "Threads");
EXPECT_CONTAINS(output, "create_vm");
#ifdef _WINDOWS
}
#endif
EXPECT_CONTAINS(output, "jvm"); // "jvm.dll" or "libjvm.so" or similar
LOG("%s", output);

Expand Down