Skip to content

Conversation

nelanbu
Copy link
Contributor

@nelanbu nelanbu commented Sep 23, 2025

Hi all,

This pull request contains a backport of commit 40bc083 from the openjdk/jdk repository.

The commit being backported was authored by Yagmur Eren on 20 Aug 2025 and was reviewed by Albert Yang and David Holmes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8358748 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358748: Large page size initialization fails with assert "page_size must be a power of 2" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk25u.git pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/234.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back nelanbu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@nelanbu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358748: Large page size initialization fails with assert "page_size must be a power of 2"

Reviewed-by: ayang, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 40bc083267c0bac64b1092c63325b8d245937b0e 8358748: Large page size initialization fails with assert "page_size must be a power of 2" Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 23, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

@nelanbu
Copy link
Contributor Author

nelanbu commented Oct 7, 2025

/approval request
Low risk backport. It adds a constraint to the -XX:LargePageSizeInBytes option.

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@nelanbu
8358748: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 7, 2025
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2025
@nelanbu
Copy link
Contributor Author

nelanbu commented Oct 21, 2025

Thanks a lot for the review @dholmes-ora, @albertnetymk!

@nelanbu
Copy link
Contributor Author

nelanbu commented Oct 21, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@nelanbu
Your change (at version 6a4fdf1) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

Going to push as commit 1d44608.
Since your change was applied there have been 99 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2025
@openjdk openjdk bot closed this Oct 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@shipilev @nelanbu Pushed as commit 1d44608.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants