Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336012: Fix usages of jtreg-reserved properties #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 12, 2024

Hi all,

This pull request contains a backport of commit e6c5aa7a from the openjdk/jdk repository.

test/jdk/java/lang/invoke/PrivateInvokeTest.java is failing on s390x JDK23 - CI consistently. error:

STDERR:
STARTED    test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst'
java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:588)
	at java.base/java.lang.Integer.parseInt(Integer.java:685)
	at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485)
FAILED     test.java.lang.invoke.PrivateInvokeTest::testFirst 'testFirst' [60ms]
STARTED    test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect'
java.lang.NumberFormatException: For input string: "Verbose[p=SUMMARY,f=FULL,e=FULL,t=false,m=false]"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:588)
	at java.base/java.lang.Integer.parseInt(Integer.java:685)
	at test.java.lang.invoke.PrivateInvokeTest.<init>(PrivateInvokeTest.java:72)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485)
FAILED     test.java.lang.invoke.PrivateInvokeTest::testInvokeDirect 'testInvokeDirect' [4ms]
JavaTest Message: JUnit Platform Failure(s): 2

[ JUnit Containers: found 4, started 4, succeeded 4, failed 0, aborted 0, skipped 0]
[ JUnit Tests: found 2, started 2, succeeded 0, failed 2, aborted 0, skipped 0]

java.lang.Exception: JUnit test failure
	at com.sun.javatest.regtest.agent.JUnitRunner.runWithJUnitPlatform(JUnitRunner.java:155)
	at com.sun.javatest.regtest.agent.JUnitRunner.main(JUnitRunner.java:99)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)

JavaTest Message: Test threw exception: java.lang.Exception
JavaTest Message: shutting down test

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336012 needs maintainer approval

Issue

  • JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/jdk23u.git pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/222.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 8336012: Fix usages of jtreg-reserved properties Nov 12, 2024
@openjdk
Copy link

openjdk bot commented Nov 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2024

Webrevs

@offamitkumar
Copy link
Member Author

/approval request test failure (PrivateInvokeTest.java) is still there jdk23u. This is trivial test fix with low risk. Tested on s390x.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@offamitkumar
8336012: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant