Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338449: ubsan: division by zero in sharedRuntimeTrans.cpp #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 13, 2024

clean after adding static to __ieee754_pow see 8252136


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338449 needs maintainer approval

Issue

  • JDK-8338449: ubsan: division by zero in sharedRuntimeTrans.cpp (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1150/head:pull/1150
$ git checkout pull/1150

Update a local copy of the PR:
$ git checkout pull/1150
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1150

View PR using the GUI difftool:
$ git pr show -t 1150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 37cfaa8deb4cc15864bb6dc2c8a87fc97cff2f0d 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. The small addition from openjdk/jdk@09d4936 LGTM.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants