Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows #1132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Nov 7, 2024

Hi all,

I want to backport JDK-8333427 for jdk21u.
This is clean backport. It changes only one test.

Testing: langtools/tools/javac/newlines/NewLineTest.java


Progress

  • Change must not contain extraneous whitespace
  • JDK-8333427 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1132/head:pull/1132
$ git checkout pull/1132

Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1132

View PR using the GUI difftool:
$ git pr show -t 1132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1132.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2024

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1b0281dc77f41fc5df323c7f7b25a4138b1ffb9e 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows Nov 7, 2024
@openjdk
Copy link

openjdk bot commented Nov 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant