8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows #1132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I want to backport JDK-8333427 for jdk21u.
This is clean backport. It changes only one test.
Testing: langtools/tools/javac/newlines/NewLineTest.java
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1132/head:pull/1132
$ git checkout pull/1132
Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1132/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1132
View PR using the GUI difftool:
$ git pr show -t 1132
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1132.diff
Using Webrev
Link to Webrev Comment