Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338389: [JFR] Long strings should be added to the string pool #1109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 30, 2024

Hi all,

This pull request contains a backport of commit d5c6158c from the openjdk/jdk repository.

The commit being backported was authored by Joakim Nordström on 27 Aug 2024 and was reviewed by Markus Grönlund.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338389 needs maintainer approval

Issue

  • JDK-8338389: [JFR] Long strings should be added to the string pool (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1109/head:pull/1109
$ git checkout pull/1109

Update a local copy of the PR:
$ git checkout pull/1109
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1109

View PR using the GUI difftool:
$ git pr show -t 1109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1109.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 30, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d5c6158cedfd96a9f97d83355b10730b81274648 8338389: [JFR] Long strings should be added to the string pool Oct 30, 2024
@openjdk
Copy link

openjdk bot commented Oct 30, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review November 4, 2024 20:44
@openjdk
Copy link

openjdk bot commented Nov 4, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Nov 4, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant