Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321470: ThreadLocal.nextHashCode can be static final #1099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 26, 2024

Backporting JDK-8321470: ThreadLocal.nextHashCode can be static final. Minor change makes the variable final (it is already static). Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321470 needs maintainer approval

Issue

  • JDK-8321470: ThreadLocal.nextHashCode can be static final (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1099/head:pull/1099
$ git checkout pull/1099

Update a local copy of the PR:
$ git checkout pull/1099
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1099

View PR using the GUI difftool:
$ git pr show -t 1099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1099.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2024

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c42535f1110d60d1472080ad4fcadb8acbeb4c4b 8321470: ThreadLocal.nextHashCode can be static final Oct 26, 2024
@openjdk
Copy link

openjdk bot commented Oct 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2024

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2024

Webrevs

@satyenme
Copy link
Author

/approval request Clean backport. Optimizing code by making ThreadLocal.nextHashCode final. Tested with tier1, tier2, and GHA tests. Risk is low.

@openjdk
Copy link

openjdk bot commented Oct 26, 2024

@satyenme
8321470: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant