Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2025

Clean backport form 21.

Test does not compile as https://bugs.openjdk.org/browse/JDK-8277090 8277090: jsr166 refresh for jdk19
is not in 17. That change makes ExecutorService implement Autoclosable.

Replaced missing close() by its implementation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359477 needs maintainer approval

Issue

  • JDK-8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4055/head:pull/4055
$ git checkout pull/4055

Update a local copy of the PR:
$ git checkout pull/4055
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4055

View PR using the GUI difftool:
$ git pr show -t 4055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4055.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport e1681c48287bcce6c8f617d9c0c25354dd62870a 8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant