Skip to content

8358334: C2/Shenandoah: incorrect execution with Unsafe #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Jul 18, 2025

21u patch doesn't apply cleanly but only because some code that's
replaced still uses NULL instead of nullptr. Otherwise, patch is
identical to 21u patch.

Tested with hotspot_gc_shenandoah + tier1 with -XX:+UseShenandoahGC


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8358334 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358334: C2/Shenandoah: incorrect execution with Unsafe (Bug - P2 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3770/head:pull/3770
$ git checkout pull/3770

Update a local copy of the PR:
$ git checkout pull/3770
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3770/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3770

View PR using the GUI difftool:
$ git pr show -t 3770

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3770.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 23069e9163c4d416aa9861bc0c7beb37a71dbfa7 8358334: C2/Shenandoah: incorrect execution with Unsafe Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

⚠️ @rwestrel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jul 18, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants