Skip to content

8347826: Introspector shows wrong method list after 8071693 #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkia
Copy link

@wkia wkia commented Jun 5, 2025

This is backport of "8347826: Introspector shows wrong method list after 8071693"

The backport is almost clean, the only conflicts were in copyright year in 2 files.


Progress

  • JDK-8347826 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347826: Introspector shows wrong method list after 8071693 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3618/head:pull/3618
$ git checkout pull/3618

Update a local copy of the PR:
$ git checkout pull/3618
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3618

View PR using the GUI difftool:
$ git pr show -t 3618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3618.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c5f235c000db6654493ea109008dbccf97f01678 8347826: Introspector shows wrong method list after 8071693 Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@wkia
Copy link
Author

wkia commented Jun 6, 2025

/approval request I'd like to backport this to 17u. The backport is almost clean. PR checks are OK. This backport fixes the wrong method and property list returning by Introspector broken after 8071693 in 17.0.14.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@wkia
8347826: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 6, 2025
@anuj-ion
Copy link

anuj-ion commented Jun 21, 2025

Hi, this request is about backporting fix to Java 17 (JDK-8347826). Backport request for same fix on Java 21 was completed 2 weeks back (JDK-8358779). If someone can take a look, it would be very helpful.
Many thanks,
Anuj

@anuj-ion
Copy link

anuj-ion commented Jul 4, 2025

@GoeLin , Sir, you validated same request for JDK21 last month. Can you please help to move this PR as well.
Many thanks,
Anuj

@anuj-ion
Copy link

@wkia, PR still pending approval. We are eagerly waiting for it to merge in main branch so that we are able to upgrade to latest stable JDK17.

@wkia
Copy link
Author

wkia commented Jul 15, 2025

@anuj-ion AFAIU the change was deferred to the next release, at least the JDK bug's label seems so.

@anuj-ion
Copy link

@wkia , Ah, I didn't notice the label. Thanks for sharing this info. Will it be a candidate for 17.0.18?

@wkia
Copy link
Author

wkia commented Jul 16, 2025

@anuj-ion yes, I hope so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants