8320682: [AArch64] C1 compilation fails with "Field too big for insn"

[bulasevich]

This is a backport from openjdk/jdk#16951 to change the NMethodSizeLimit limit to 1MB to avoid the issue:

$ jdk-fastdebug/bin/java -XX:NMethodSizeLimit=10M -version

# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/jdk17u-dev/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:267), pid=334227, tid=334241
#  guarantee(chk == -1 || chk == 0) failed: Field too big for insn

The minor merge conflicts have been resolved:

• Copyright year
• TestC1Globals.java in the original fix was an update of an already existing file. Here is is just a new file

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320682 needs maintainer approval

Issue

• JDK-8320682: [AArch64] C1 compilation fails with "Field too big for insn" (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3432/head:pull/3432
$ git checkout pull/3432

Update a local copy of the PR:
$ git checkout pull/3432
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3432

View PR using the GUI difftool:
$ git pr show -t 3432

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3432.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320682: [AArch64] C1 compilation fails with "Field too big for insn"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• d50fbcd: 8321718: ProcessTools.executeProcess calls waitFor before logging
• 3f9d801: 8318962: Update ProcessTools javadoc with suggestions in 8315097
• 3dbeb83: 8314320: Mark runtime/CommandLine/ tests as flagless
• ... and 56 more: https://git.openjdk.org/jdk17u-dev/compare/c98e598bc4b369abc60a876f7cfb7c78f5521cc1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

[mlbridge]

Webrevs

• 00: Full (3ecde249)

[openjdk]

⚠️ @bulasevich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bulasevich]

/approval request
The issue is applicable to jdk17u as well. The change is safe and well tested.

[openjdk]

@bulasevich
8320682: The approval request has been created successfully.

[bulasevich]

/integrate

[openjdk]

@bulasevich
Your change (at version 3ecde24) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit bec2e07.
Since your change was applied there have been 59 commits pushed to the master branch:

• d50fbcd: 8321718: ProcessTools.executeProcess calls waitFor before logging
• 3f9d801: 8318962: Update ProcessTools javadoc with suggestions in 8315097
• 3dbeb83: 8314320: Mark runtime/CommandLine/ tests as flagless
• ... and 56 more: https://git.openjdk.org/jdk17u-dev/compare/c98e598bc4b369abc60a876f7cfb7c78f5521cc1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @bulasevich Pushed as commit bec2e07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.