Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284093: Memory leak: X11SD_DisposeXImage should also free obdata #2616

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 20, 2024

Hi all,

This pull request contains a backport of commit 205cfb84 from the openjdk/jdk repository.

The commit being backported was authored by Zhengyu Gu on 11 Apr 2022 and was reviewed by Phil Race and Andrew John Hughes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8284093 needs maintainer approval

Issue

  • JDK-8284093: Memory leak: X11SD_DisposeXImage should also free obdata (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2616/head:pull/2616
$ git checkout pull/2616

Update a local copy of the PR:
$ git checkout pull/2616
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2616

View PR using the GUI difftool:
$ git pr show -t 2616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2616.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 205cfb84968fe93cbfe7d509e1e7d051ed05f97c 8284093: Memory leak: X11SD_DisposeXImage should also free obdata Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

This backport pull request has now been updated with issue from the original commit.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

@mrserb This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 10, 2024
@mrserb
Copy link
Member Author

mrserb commented Oct 18, 2024

/open

@openjdk openjdk bot reopened this Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@mrserb This pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant