Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8026976: ECParameters, Point does not match field size #2958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Oct 21, 2024

Hi all,

This is a backport of JDK-8026976: ECParameters, Point does not match field size

Original patch apply cleanly to 11u.

Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8026976 needs maintainer approval

Issue

  • JDK-8026976: ECParameters, Point does not match field size (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2958/head:pull/2958
$ git checkout pull/2958

Update a local copy of the PR:
$ git checkout pull/2958
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2958

View PR using the GUI difftool:
$ git pr show -t 2958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2958.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 55f5542ca2104df91e14693534cc7b3c36e81953 8026976: ECParameters, Point does not match field size Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2024

Webrevs

@kurashige23
Copy link
Contributor Author

/approval request Clean backport. The risk is low because the fix to the source is only for P11ECKeyFactory.java and it is just addition of switching by UseEcX963Encoding. pkcs11 tests on RHEL9 and GHA tests pass.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

@kurashige23
8026976: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 21, 2024
@kurashige23
Copy link
Contributor Author

Could anyone review this backport please?

1 similar comment
@kurashige23
Copy link
Contributor Author

Could anyone review this backport please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant