8370489: Some compiler tests miss the @key randomness

[sarannat]

Issue: Some compiler tests uses randomization but does not have @key randomness in the jtreg header.

Fix: The list of test cases that did not have @key randomness were listed using grep -l "getRandomInstance" -r test/hotspot/jtreg/compiler/ | xargs grep -L "randomness". This PR adds @key randomness to these tests.

Note: The following tests that are still listed with grep -l "getRandomInstance" -r test/hotspot/jtreg/compiler/ | xargs grep -L "randomness" after this PR are confirmed to be helper or support file for actual test.
test/hotspot/jtreg/compiler/codegen/aes/TestAESBase.java
test/hotspot/jtreg/compiler/compilercontrol/jcmd/StressAddJcmdBase.java
test/hotspot/jtreg/compiler/compilercontrol/parser/HugeDirectiveUtil.java
test/hotspot/jtreg/compiler/compilercontrol/share/scenario/CommandGenerator.java
test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java
test/hotspot/jtreg/compiler/lib/ir_framework/test/ArgumentValue.java
test/hotspot/jtreg/compiler/lib/ir_framework/AbstractInfo.java
test/hotspot/jtreg/compiler/lib/ir_framework/CompLevel.java
test/hotspot/jtreg/compiler/lib/generators/Generators.java
test/hotspot/jtreg/compiler/lib/template_framework/library/PrimitiveType.java
test/hotspot/jtreg/compiler/lib/template_framework/library/Expression.java
test/hotspot/jtreg/compiler/lib/template_framework/NameSet.java
test/hotspot/jtreg/compiler/intrinsics/mathexact/Verify.java
test/hotspot/jtreg/compiler/intrinsics/bmi/BMITestRunner.java
test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressBooleanArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressIntArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressLongArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressCharArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressObjectArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressByteArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressFloatArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressShortArrayCopy.java
test/hotspot/jtreg/compiler/arraycopy/stress/StressDoubleArrayCopy.java
test/hotspot/jtreg/compiler/codecache/cli/codeheapsize/JVMStartupRunner.java
test/hotspot/jtreg/compiler/vectorapi/reshape/utils/VectorReshapeHelper.java
test/hotspot/jtreg/compiler/jvmci/compilerToVM/DummyClass.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370489: Some compiler tests miss the @key randomness (Bug - P5)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Damon Fenacci (@dafedafe - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28463/head:pull/28463
$ git checkout pull/28463

Update a local copy of the PR:
$ git checkout pull/28463
$ git pull https://git.openjdk.org/jdk.git pull/28463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28463

View PR using the GUI difftool:
$ git pr show -t 28463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28463.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snatarajan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sarannat This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370489: Some compiler tests miss the @key randomness

Reviewed-by: chagedorn, dfenacci

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 425 new commits pushed to the master branch:

• 43af7b5: 8371309: Diagnostic.getEndPosition can throw an NPE with typical broken code
• 3f47e57: 8372240: Convert FreeListAllocator to use Atomic
• e18e95e: 8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build
• ... and 422 more: https://git.openjdk.org/jdk/compare/2f613911d58478913dc482e1500d3fbab74408b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sarannat The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fe6403d0)

[chhagedorn]

Looks good and trivial, thanks for cleaning these up!

[chhagedorn]

Suggested change

	package compiler.vectorization;
	import java.util.Random;
	package compiler.vectorization;
	import java.util.Random;

[dafedafe]

Thanks for the cleanup @sarannat. Looks good to me.

[dafedafe]

Do we need javadoc style comments for JTreg? (we don't seem to be too consistent in our tests)