Skip to content

Conversation

@kieran-farrell
Copy link
Contributor

@kieran-farrell kieran-farrell commented Nov 20, 2025

Replacing 'global identifier' with 'UUID' for consistancy in the spec as suggested during the review of JDK-8334015.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370910: Cleanup terminology of UUID vs Global Identifiers in UUID (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28435/head:pull/28435
$ git checkout pull/28435

Update a local copy of the PR:
$ git checkout pull/28435
$ git pull https://git.openjdk.org/jdk.git pull/28435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28435

View PR using the GUI difftool:
$ git pr show -t 28435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28435.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2025

👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@kieran-farrell This change is no longer ready for integration - check the PR body for details.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@kieran-farrell The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

@RogerRiggs
Copy link
Contributor

Looks straight-forward.
There is a typo in the PR description of the earlier issue, should be 8334025.

@kieran-farrell
Copy link
Contributor Author

PR description edited to include correct Bug ID

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2025
@@ -35,7 +35,7 @@
* A class that represents an immutable universally unique identifier (UUID).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to "Universally Unique IDentifier (UUID)" too.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 21, 2025
* A UUID represents a 128-bit value.
*
* <p> There exist different variants of these global identifiers. The methods
* <p> There exist different variants of these UUIDs. The methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about replacing this paragraph with this:

"This class is primarily designed for manipulating Leach-Salz variant UUIDs, but it also supports the creation of UUIDs of other variants."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants