8369736 - Add management interface for AOT cache creation #28010

macarte · 2025-10-28T01:17:57Z

Add jdk.management.AOTCacheMXBean. The interface provides a single action that when called will cause any hosted JVM currently recording AOT information will stop recording. Existing functionality is preserved: when stopped the JVM will create the required artifacts based on the execution mode. Conveniently as the application running on the JVM has not stopped (as was previously the only way to stop recording), the application will resume execution after the artifacts have been generated.

The interface will return TRUE if a recording was successfully stopped, in all other cases (not recording etc.) will return FALSE

It follows that invoking the action on a JVM that is recording, twice in succession, should (baring internal errors) produce the following two responses:

TRUE
FALSE

Passes tier1 on linux (x64) and windows (x64)

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8369737 to be approved

Integration blocker

⚠️ Dependency #27965 must be integrated first

Issues

JDK-8369736: Add management interface for AOT cache creation (Enhancement - P3)
JDK-8369737: Add management interface for AOT cache creation (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28010/head:pull/28010
$ git checkout pull/28010

Update a local copy of the PR:
$ git checkout pull/28010
$ git pull https://git.openjdk.org/jdk.git pull/28010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28010

View PR using the GUI difftool:
$ git pr show -t 28010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28010.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-10-28T01:18:55Z

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into pr/27965 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-28T01:19:22Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2025-10-28T01:20:19Z

@macarte The following labels will be automatically applied to this pull request:

hotspot
jmx
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-28T01:26:34Z

Webrevs

01: Full - Incremental (2285a683)
00: Full (d58c5147)

AlanBateman · 2025-10-28T09:51:18Z

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java

+       * </blockquote>
+       *
+       * @return {@code true} if a recording was in progress and has been ended successfully; {@code false} otherwise.
+       */


There are issues in the javadoc that will cause the docs target to fail, e.g. mismatched blockquote. Can you fix these up so that we can generate the docs from the changes in the PR?

Is there an easy way to test the correctness of the javadoc parts (I couldn't find an option for javadoc). The </blockquote >above is matched to a <blockquote> on line 88, but there is a <pre></pre> pair in between, is that the issue you are referring to?

make docs. The second blockquote is matched with another blockquote, not </blockquote>. In the example, which can be converted to a snippet, then then braces not matched so the end brace for {@code ... } get mixed up.

I see that now - fixing ....

AlanBateman · 2025-10-28T09:55:06Z

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java

+
+import java.lang.management.ManagementFactory;
+import java.lang.management.PlatformManagedObject;
+import java.util.concurrent.ForkJoinPool;


I assume there is no need to import ForkJoinPool.

AlanBateman · 2025-10-28T09:55:49Z

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java

+/**
+ * Management interface for the JDK's Ahead of Time (AOT) optimizations.
+ *
+ * Currently, {@code HotSpotAOTCacheMXBean} defines one operation at this time to end the AOT recording.


I think you drop "Currently, ", it will be a bit clearer without it.

AlanBateman · 2025-10-28T10:01:14Z

test/hotspot/jtreg/runtime/cds/appcds/aotCache/HotSpotAOTCacheMXBeanTest.java

+class HotSpotAOTCacheMXBeanApp {
+    public static void main(String[] args) {
+        System.out.println("Hello Leyden " + args[0]);
+        var aotBean = ManagementFactory.getPlatformMXBean(HotSpotAOTCacheMXBean.class);


This uses MF.getPlatformMXBean in the child VM. A more complete test would repeat with:

MBeanServer server = ManagementFactory.getPlatformMBeanServer(); HotSpotAOTCacheMXBean bean = ManagementFactory.newPlatformMXBeanProxy(server, "jdk.management:type=HotSpotAOTCacheMXBean", HotSpotAOTCacheMXBean.class);

In any case, it might be simpler to test that the MXBean is registered in the test itself, it doesn't need to be in the child VM.

DanHeidinga · 2025-10-28T14:30:42Z

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java

+import javax.management.ObjectName;
+
+/**
+ * Management interface for the JDK's Ahead of Time (AOT) optimizations.


I don't like the word "optimizations" here but don't have a better one. Maybe "operation"? Still not great

Well, one possible alternative is kind of implicit in the bean name:

"Management interface for the JDK's Ahead of Time (AOT) Cache"

src/jdk.management/share/classes/jdk/management/HotSpotAOTCacheMXBean.java

…eMXBean.java Co-authored-by: Dan Heidinga <[email protected]>

8369736 - Adding HotSpotAOTCache MXBean

ff1d9fe

Removed extra functionality

74537ff

openjdk bot added csr Pull request needs approved CSR before integration serviceability [email protected] jmx [email protected] hotspot [email protected] labels Oct 28, 2025

Removed whitespace

d58c514

openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025

AlanBateman reviewed Oct 28, 2025

View reviewed changes

DanHeidinga reviewed Oct 28, 2025

View reviewed changes

macarte and others added 2 commits October 28, 2025 11:55

Update src/jdk.management/share/classes/jdk/management/HotSpotAOTCach…

993f618

…eMXBean.java Co-authored-by: Dan Heidinga <[email protected]>

Update src/jdk.management/share/classes/jdk/management/HotSpotAOTCach…

2285a68

…eMXBean.java Co-authored-by: Dan Heidinga <[email protected]>

Uh oh!

8369736 - Add management interface for AOT cache creation #28010

Are you sure you want to change the base?

8369736 - Add management interface for AOT cache creation #28010

Uh oh!

Conversation

macarte commented Oct 28, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Integration blocker

Issues

Reviewing

Uh oh!

bridgekeeper bot commented Oct 28, 2025

Uh oh!

openjdk bot commented Oct 28, 2025

Uh oh!

openjdk bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

AlanBateman Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

macarte Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlanBateman Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

macarte Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

DanHeidinga Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

adinn Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

macarte commented Oct 28, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 28, 2025 •

edited

Loading

mlbridge bot commented Oct 28, 2025 •

edited

Loading

AlanBateman Oct 28, 2025 •

edited

Loading

macarte Oct 28, 2025 •

edited

Loading