Skip to content

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Oct 27, 2025

Hi, please consider.

Sanity tested and no issues with MAJIK t1 (with +VSC).

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370708: RISC-V: Add VerifyStackAtCalls (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28005/head:pull/28005
$ git checkout pull/28005

Update a local copy of the PR:
$ git checkout pull/28005
$ git pull https://git.openjdk.org/jdk.git pull/28005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28005

View PR using the GUI difftool:
$ git pr show -t 28005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28005.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370708: RISC-V: Add VerifyStackAtCalls

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 05ef8f4: 8370853: IGV: SEGV in IdealGraphPrinter::print after JDK-8370569
  • d8515f0: 8369983: Remove expired ZGC flags for JDK 26
  • bbe5e83: 8363925: Remove unused sun.nio.cs.ArrayEncoder::encode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@robehn robehn changed the title 8370708: RISC-V: Add VerifyStackAtCallsDraft 8370708: RISC-V: Add VerifyStackAtCalls Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Oct 28, 2025

Fixed, thanks for having a look!

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2025
@robehn
Copy link
Contributor Author

robehn commented Oct 28, 2025

Thanks for reviewing!

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 28, 2025
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants