8323999: KeyAgreement cannot be initiated again after a failed initialization #28004
      
        
          +72
        
        
          −0
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR updates KeyAgreement to re-initialize the
serviceIteratorfield when chooseProvider() is called and serviceIterator.hasNext() returns false. This can happen if KeyAgreement object has been initialized with an invalid key and then initialized with a valid key. (See accompanying test.)Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28004/head:pull/28004$ git checkout pull/28004Update a local copy of the PR:
$ git checkout pull/28004$ git pull https://git.openjdk.org/jdk.git pull/28004/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28004View PR using the GUI difftool:
$ git pr show -t 28004Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28004.diff
Using Webrev
Link to Webrev Comment