8363925: Remove unused sun.nio.cs.ArrayEncoder::encode

[vy]

JDK-6636319 introduced ArrayEncoder, composed of only encode method. Later on JDK-8054307 (JEP 254: Compact Strings) removed all its usages. This method can safely be removed, hence this PR. Confirmed that tier1-2 tests are clear on several platforms after changes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8363925: Remove unused sun.nio.cs.ArrayEncoder::encode (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27999/head:pull/27999
$ git checkout pull/27999

Update a local copy of the PR:
$ git checkout pull/27999
$ git pull https://git.openjdk.org/jdk.git pull/27999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27999

View PR using the GUI difftool:
$ git pr show -t 27999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27999.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363925: Remove unused sun.nio.cs.ArrayEncoder::encode

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• c3c0a67: 8370500: Change windows x64 implementation of os::current_stack_pointer()
• 5dd8a33: 8334898: Resolve static field/method references at CDS dump time
• 5c5367c: 8370569: IGV: dump more graph properties at bytecode parsing
• ... and 22 more: https://git.openjdk.org/jdk/compare/e9479b517ad8b6eac7244057644f90e710bd74b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vy The following labels will be automatically applied to this pull request:

• i18n
• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (7fc52675)
• 02: Full - Incremental (c599d8d3)
• 01: Full - Incremental (a8c471f2)
• 00: Full (ac07c09d)

[liach]

I recommend further refactors, at least turn the 3 default methods to abstract methods. After removal of ineffective CESU_8, we can make the default methods abstract to improve safety.

Down the road, we can remove the -1 handling at use site, and also pass in dp explicitly (I recall this being useful for optimizing Writer/OutputStream)

[openjdk]

@vy Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@vy core-libs has been added to this pull request based on files touched in new commit(s).

[vy]

@liach, thanks so much for the review! 🙇

I recommend further refactors, at least turn the 3 default methods to abstract methods.
After removal of ineffective CESU_8, we can make the default methods abstract to improve safety.
Down the road, we can remove the -1 handling at use site, and also pass in dp explicitly

All done in 7fc5267.

I recall this [passing dp explicitly] being useful for optimizing Writer/OutputStream

Skimmed through ArrayEncoder::encodeFrom* call-sites, but could not spot anything particular that can quickly be addressed.

Please let me know if there are any changes I can carry out within the scope of this JBS/PR.

[liach]

Thank you for this great cleanup. Looks much more maintainable and straightforward. We can re-implement for CESU_8 if there is request later.