Skip to content

Conversation

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Oct 24, 2025

Throughout documentation and source code, the Thread.interrupted flag is referred to as either "interrupted status" or "interrupt status". It might be good to be consistent.

Historically, it seems to have initially been "interrupted status". This is how the flag is called in java.lang.Thread and the "Java Concurrency in Practice" book. ("The Java Programming Language" calls it "interrupted state".) However, over the years "interrupt status" appeared in documentation and source code through networking and NIO classes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370568: Refer to Thread.interrupted as "interrupted status" consistently (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27972/head:pull/27972
$ git checkout pull/27972

Update a local copy of the PR:
$ git checkout pull/27972
$ git pull https://git.openjdk.org/jdk.git pull/27972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27972

View PR using the GUI difftool:
$ git pr show -t 27972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27972.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370568: Refer to Thread.interrupted as "interrupted status" consistently

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@pavelrappo The following labels will be automatically applied to this pull request:

  • build
  • client
  • compiler
  • core-libs
  • hotspot-gc
  • net
  • nio
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@pavelrappo pavelrappo marked this pull request as ready for review October 27, 2025 17:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants