-
Couldn't load subscription status.
- Fork 6.1k
8370568: Refer to Thread.interrupted as "interrupted status" consistently #27972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
|
@pavelrappo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@pavelrappo The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Throughout documentation and source code, the
Thread.interruptedflag is referred to as either "interrupted status" or "interrupt status". It might be good to be consistent.Historically, it seems to have initially been "interrupted status". This is how the flag is called in
java.lang.Threadand the "Java Concurrency in Practice" book. ("The Java Programming Language" calls it "interrupted state".) However, over the years "interrupt status" appeared in documentation and source code through networking and NIO classes.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27972/head:pull/27972$ git checkout pull/27972Update a local copy of the PR:
$ git checkout pull/27972$ git pull https://git.openjdk.org/jdk.git pull/27972/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27972View PR using the GUI difftool:
$ git pr show -t 27972Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27972.diff
Using Webrev
Link to Webrev Comment