8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 #27635

prsadhuk · 2025-10-05T05:37:38Z

Test fails to pick red color from JLabel in ubuntu24.04 even though it passes is ubuntu 22.04.
Seems like the red pixel from the font is not being picked up despite the fact that label foreground color actually is rendered in red.

It is seen in ubuntu 22.04 the font used for JLabel is "family=DejaVu Sans,name=DejaVu Sans,style=plain,size=12"
while in ubuntu 24.04 the font used for JLabel is "family=Noto Sans,name=Noto Sans,style=plain,size=12"

I have made it consistent across version using same font and made it larger and bold and using such text for easier pickup of redpixel.
It passes in all platforms including ubuntu24.04

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Damon Nguyen (@DamonGuy - Committer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27635/head:pull/27635
$ git checkout pull/27635

Update a local copy of the PR:
$ git checkout pull/27635
$ git pull https://git.openjdk.org/jdk.git pull/27635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27635

View PR using the GUI difftool:
$ git pr show -t 27635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27635.diff

Using Webrev

Link to Webrev Comment

…r on Ubuntu 24.04

bridgekeeper · 2025-10-05T05:38:40Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-05T05:39:54Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04

Reviewed-by: aivanov, dnguyen, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 168 new commits pushed to the master branch:

910bb68: 8349847: Support configuring individual lint categories as errors
6bfd018: 8366002: Beans.instantiate needs to describe the lookup procedure
7f070d3: 8369246: Use https in make/devkit scripts
... and 165 more: https://git.openjdk.org/jdk/compare/2aafda1968f3fc8902f7d146a1cba72998aeb976...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-05T05:40:27Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-05T05:44:36Z

Webrevs

01: Full - Incremental (a656dd07)
00: Full (537d53d3)

aivanov-jdk · 2025-10-07T09:18:03Z

test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java

@@ -71,7 +71,8 @@ private static void test(UIManager.LookAndFeelInfo laf) {
            UIManager.getDefaults().put("Label.foreground", labelColor);
        }

-        JLabel label = new JLabel("<html><body>Can You Read This?</body></html>");
+        JLabel label = new JLabel("<html><body>WWWWWWWWWMMMMMMM?</body></html>");


Full block character, \u2588, to ensure the entire label is filled with red color?

Yes, that can be used..Modified...We have used for another JRadioButton synth test if I am not wrong

aivanov-jdk · 2025-10-07T17:23:29Z

test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java

@@ -71,7 +71,7 @@ private static void test(UIManager.LookAndFeelInfo laf) {
            UIManager.getDefaults().put("Label.foreground", labelColor);
        }

-        JLabel label = new JLabel("<html><body>Can You Read This?</body></html>");
+        JLabel label = new JLabel("<html><body>\u2588 \u2588 \u2588 \u2588</body></html>");


Suggested change

JLabel label = new JLabel("<html><body>\u2588 \u2588 \u2588 \u2588</body></html>");

JLabel label = new JLabel("<html><body>\u2588\u2588\u2588\u2588</body></html>");

No one sees the text, spaces aren't necessary.

A comment will clarify what the Unicode character is used and why. Otherwise, it looks good to me.

DamonGuy

Tested on both my 22.04 and 24.04 and it seems to be consistent to me now. LGTM.

prsadhuk · 2025-10-08T02:59:14Z

/integrate

openjdk · 2025-10-08T03:00:36Z

Going to push as commit 650fd35.
Since your change was applied there have been 169 commits pushed to the master branch:

4ee6079: 8369328: Use uppercase variable names in the devkit makefiles
910bb68: 8349847: Support configuring individual lint categories as errors
6bfd018: 8366002: Beans.instantiate needs to describe the lookup procedure
... and 166 more: https://git.openjdk.org/jdk/compare/2aafda1968f3fc8902f7d146a1cba72998aeb976...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-08T03:00:44Z

@prsadhuk Pushed as commit 650fd35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8335646: Nimbus : JLabel not painted with LAF defined foreground colo…

537d53d

…r on Ubuntu 24.04

openjdk bot added the client [email protected] label Oct 5, 2025

openjdk bot added the rfr Pull request is ready for review label Oct 5, 2025

aivanov-jdk reviewed Oct 7, 2025

View reviewed changes

Use full block red char

a656dd0

aivanov-jdk approved these changes Oct 7, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2025

DamonGuy approved these changes Oct 7, 2025

View reviewed changes

mrserb approved these changes Oct 7, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 8, 2025

openjdk bot closed this Oct 8, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2025

prsadhuk deleted the JDK-8335646 branch October 8, 2025 03:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 #27635

8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 #27635

prsadhuk commented Oct 5, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Oct 5, 2025

Uh oh!

openjdk bot commented Oct 5, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Oct 5, 2025 •

edited

Loading

Uh oh!

mlbridge bot commented Oct 5, 2025 •

edited

Loading

Uh oh!

aivanov-jdk Oct 7, 2025

Uh oh!

prsadhuk Oct 7, 2025

Uh oh!

aivanov-jdk Oct 7, 2025

Uh oh!

aivanov-jdk Oct 7, 2025

Uh oh!

DamonGuy left a comment

Uh oh!

prsadhuk commented Oct 8, 2025

Uh oh!

openjdk bot commented Oct 8, 2025

Uh oh!

openjdk bot commented Oct 8, 2025

Uh oh!

Uh oh!

	JLabel label = new JLabel("<html><body>\u2588 \u2588 \u2588 \u2588</body></html>");
	JLabel label = new JLabel("<html><body>\u2588\u2588\u2588\u2588</body></html>");

8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 #27635

8335646: Nimbus : JLabel not painted with LAF defined foreground color on Ubuntu 24.04 #27635

Conversation

prsadhuk commented Oct 5, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 5, 2025

Uh oh!

openjdk bot commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

aivanov-jdk Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

DamonGuy left a comment

Choose a reason for hiding this comment

Uh oh!

prsadhuk commented Oct 8, 2025

Uh oh!

openjdk bot commented Oct 8, 2025

Uh oh!

openjdk bot commented Oct 8, 2025

Uh oh!

Uh oh!

prsadhuk commented Oct 5, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 5, 2025 •

edited

Loading

openjdk bot commented Oct 5, 2025 •

edited

Loading

mlbridge bot commented Oct 5, 2025 •

edited

Loading