8366040: Change URL.lookupViaProviders to use ScopedValue to detect recursive lookup #27623
Conversation
|
Passing |
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| throw new Error("Circular loading of URL stream handler providers detected"); | ||
| } | ||
| try { | ||
| return ScopedValue.where(IN_LOOKUP, true).call(() -> { |
There was a problem hiding this comment.
We should never reach here if the VM is not booted, or if the protocol is file: or jrt: - so it may be safe to use a lambda. The alternative would be to use an anonymous class and create a new Runnable() { ... } but it's probably not needed.
There was a problem hiding this comment.
The changes to URL look okay but good to run any startup benchmarks to check startup performance.
| resultChecker, | ||
| TEST_SRC.resolve("circular.provider.template"), | ||
| sysProps); | ||
| } |
There was a problem hiding this comment.
I assume you've re-format the changes to Basic.java to be consistent with this existing code in the test (looks a bit strange on first sighting to see a completely different style being introduced).
Replace
ThreadTrackerusage injava.net.URLwithScopedValueand add a test.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27623/head:pull/27623$ git checkout pull/27623Update a local copy of the PR:
$ git checkout pull/27623$ git pull https://git.openjdk.org/jdk.git pull/27623/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27623View PR using the GUI difftool:
$ git pr show -t 27623Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27623.diff
Using Webrev
Link to Webrev Comment