-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8369041: Release memory after testing in ThreadsRunner.java #27606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@albertnetymk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/cc hotspot-gc |
@albertnetymk |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like these cleanup calls belong in finally
block, so that they get cleaned up even on exception?
Thanks for review. /integrate |
Going to push as commit 596af0a.
Your commit was automatically rebased without conflicts. |
@albertnetymk Pushed as commit 596af0a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Small patch of cleaning up no longer used data structures after testing is complete.
Test: tier1-5
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27606/head:pull/27606
$ git checkout pull/27606
Update a local copy of the PR:
$ git checkout pull/27606
$ git pull https://git.openjdk.org/jdk.git pull/27606/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27606
View PR using the GUI difftool:
$ git pr show -t 27606
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27606.diff
Using Webrev
Link to Webrev Comment