Skip to content

8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures #26412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myankelev
Copy link
Member

@myankelev myankelev commented Jul 21, 2025

When the test is run now the reason for the failure will be requested providing further feedback.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26412/head:pull/26412
$ git checkout pull/26412

Update a local copy of the PR:
$ git checkout pull/26412
$ git pull https://git.openjdk.org/jdk.git pull/26412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26412

View PR using the GUI difftool:
$ git pr show -t 26412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26412.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures Jul 21, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@mlbridge
Copy link

mlbridge bot commented Jul 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants