8342639: Global operator new in adlc has wrong exception spec

[kimbarrett]

Please review this change to remove the definition of
operator new(size_t, int, const char*, int) throw()

It doesn't seem to be needed anymore, if it ever really was. See discussion in
JBS for some more details.

Testing: mach5 tier1-5, to cover various different build configurations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342639: Global operator new in adlc has wrong exception spec (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25668/head:pull/25668
$ git checkout pull/25668

Update a local copy of the PR:
$ git checkout pull/25668
$ git pull https://git.openjdk.org/jdk.git pull/25668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25668

View PR using the GUI difftool:
$ git pr show -t 25668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25668.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342639: Global operator new in adlc has wrong exception spec

Reviewed-by: kvn, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 026975a: 8358721: Update JCov for class file version 70
• 8adb052: 8341778: Some javac tests ignore the result of JavacTask::call
• 9658cec: 8358685: [TEST] AOTLoggingTag.java failed with missing log message
• ... and 6 more: https://git.openjdk.org/jdk/compare/029e3bf8f582f7399b80c592421b2fd72737e264...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b03e0422)

[vnkozlov]

Good.

[vnkozlov]

@kimbarrett can you enable GHA testing for this branch? It will test more builds.

[TheRealMDoerr]

LGTM. Thanks for cleaning this up!

[kimbarrett]

Thanks for reviews @vnkozlov and @TheRealMDoerr

[kimbarrett]

/integrate

[openjdk]

Going to push as commit e94ad55.
Since your change was applied there have been 11 commits pushed to the master branch:

• d735255: 8345414: Google CAInterop test failures
• d024f58: 8358809: Improve link to stdin.encoding from java.lang.IO
• 026975a: 8358721: Update JCov for class file version 70
• ... and 8 more: https://git.openjdk.org/jdk/compare/029e3bf8f582f7399b80c592421b2fd72737e264...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit e94ad55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.