-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8356027: Print enhanced compilation timings #24984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8356027: Print enhanced compilation timings #24984
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Sample log after:
This shows, for example, that C1 (tier3) compilations of these small methods are really quick, and the queueing delays are comparable to the actual compilation costs. |
Caught a failure in This is a blessing in disguise: with this change, we finally can start printing the inline tree after successful compiles under the |
Webrevs
|
In Leyden, we have the extended compilation timings printouts with -XX:+PrintCompilation / UL, that are very useful to study compiler dynamics. These timings include:
We should consider the same kind of printout for mainline. This would also require us to print the compilation task after the compilation, not only before it. This improvement would also obviate any need for
PrintCompilation2
flag, JDK-8356028.The difference from the output format we ship in Leyden:
started
to clearly mark it as such.C0.1
, but that prepending makes it a bit inconvenient with scripts. This PR also does microseconds, instead of fractional milliseconds. This should be enough to capture the wide range of durations.See the sample
-XX:+PrintCompilation
output in the comments.Additional testing:
compiler
all
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24984/head:pull/24984
$ git checkout pull/24984
Update a local copy of the PR:
$ git checkout pull/24984
$ git pull https://git.openjdk.org/jdk.git pull/24984/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24984
View PR using the GUI difftool:
$ git pr show -t 24984
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24984.diff
Using Webrev
Link to Webrev Comment