-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8356025: Provide a PrintVMInfoAtExit diagnostic switch #24980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8356025: Provide a PrintVMInfoAtExit diagnostic switch #24980
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 106 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a useful 'thing' , thanks !
* @library /test/lib | ||
* @modules java.base/jdk.internal.misc | ||
* @requires vm.flagless | ||
* @requires vm.bits == "64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the bits == 64 requirement is there but maybe it is because of the other settings used by the test ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. Will be useful when testing and developing printing code.
Co-authored-by: Joel Sikström <[email protected]>
Thanks, folks! /integrate |
@tstuefe This pull request has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, missed the space in my suggestion.
Co-authored-by: Joel Sikström <[email protected]>
:-) Please re-approve (I will wait for tests to run through before integrating) |
/integrate |
@tstuefe This pull request has not yet been marked as ready for integration. |
/integrate |
1 similar comment
/integrate |
Going to push as commit da5dc52.
Your commit was automatically rebased without conflicts. |
@tstuefe The command |
Provides a
PrintVMInfoAtExit
diagnostic switch that, if active, causes the JVM to print out the equivalent ofjcmd VM.info
before exiting.The
VM.info
output contains a large range of valuable information about the JVM and the process.The switch can be surprisingly useful, e.g. when analysing short-lived processes that are too quick to be analysed with jcmd, or analysing JVM child processes in a process tree, and so on. Going forward, it can also remove the need for some of the more specific PrintxxxAtExit flags.
It can also make writing tests easier (want to make sure switch XX enables condition YY, and YY is printed as part of VM.info? Just start the VM with PrintVMInfoAtExit and parse the output )
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24980/head:pull/24980
$ git checkout pull/24980
Update a local copy of the PR:
$ git checkout pull/24980
$ git pull https://git.openjdk.org/jdk.git pull/24980/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24980
View PR using the GUI difftool:
$ git pr show -t 24980
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24980.diff
Using Webrev
Link to Webrev Comment