Skip to content

8356025: Provide a PrintVMInfoAtExit diagnostic switch #24980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented May 1, 2025

Provides a PrintVMInfoAtExit diagnostic switch that, if active, causes the JVM to print out the equivalent of jcmd VM.info before exiting.

The VM.info output contains a large range of valuable information about the JVM and the process.

The switch can be surprisingly useful, e.g. when analysing short-lived processes that are too quick to be analysed with jcmd, or analysing JVM child processes in a process tree, and so on. Going forward, it can also remove the need for some of the more specific PrintxxxAtExit flags.

It can also make writing tests easier (want to make sure switch XX enables condition YY, and YY is printed as part of VM.info? Just start the VM with PrintVMInfoAtExit and parse the output )


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356025: Provide a PrintVMInfoAtExit diagnostic switch (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24980/head:pull/24980
$ git checkout pull/24980

Update a local copy of the PR:
$ git checkout pull/24980
$ git pull https://git.openjdk.org/jdk.git pull/24980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24980

View PR using the GUI difftool:
$ git pr show -t 24980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24980.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2025

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356025: Provide a PrintVMInfoAtExit diagnostic switch

Reviewed-by: mbaesken, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8356025: Provide a PrintVMInfoAtExit diagnostic switch 8356025: Provide a PrintVMInfoAtExit diagnostic switch May 1, 2025
@openjdk
Copy link

openjdk bot commented May 1, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tstuefe tstuefe marked this pull request as ready for review May 1, 2025 10:55
@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2025
@mlbridge
Copy link

mlbridge bot commented May 1, 2025

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful 'thing' , thanks !

* @library /test/lib
* @modules java.base/jdk.internal.misc
* @requires vm.flagless
* @requires vm.bits == "64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the bits == 64 requirement is there but maybe it is because of the other settings used by the test ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 7, 2025
Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. Will be useful when testing and developing printing code.

@tstuefe
Copy link
Member Author

tstuefe commented May 7, 2025

Thanks, folks!

/integrate

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@tstuefe This pull request has not yet been marked as ready for integration.

Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed the space in my suggestion.

@tstuefe
Copy link
Member Author

tstuefe commented May 7, 2025

Ah, missed the space in my suggestion.

:-)

Please re-approve (I will wait for tests to run through before integrating)

@tstuefe
Copy link
Member Author

tstuefe commented May 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2025

@tstuefe This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 7, 2025
@tstuefe
Copy link
Member Author

tstuefe commented May 7, 2025

/integrate

1 similar comment
@tstuefe
Copy link
Member Author

tstuefe commented May 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2025

Going to push as commit da5dc52.
Since your change was applied there have been 109 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2025
@openjdk openjdk bot closed this May 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@tstuefe Pushed as commit da5dc52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@tstuefe The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants