8356022: Migrate descriptor parsing from generics to BytecodeDescriptor #24978
+58
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As another step toward the removal of the old generics infrastructure, I propose to remove the usages of generic parsing utilities and use the facilities provided by BytecodeDescriptor, already used by MethodType.fromDescriptorString. This also prevents extra validation cost in use sites to defend against generic types.
In this patch, BytecodeDescriptor and Wrapper see minor updates, mainly for better exception messages - previously, an unparseable char in the descriptor string just reports that char, and now the whole descriptor string is reported.
These behaviors are already covered by the tests added in JDK-8350704 #23788.
Testing: reflect/annotation/Class, running tier 1+2
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24978/head:pull/24978
$ git checkout pull/24978
Update a local copy of the PR:
$ git checkout pull/24978
$ git pull https://git.openjdk.org/jdk.git pull/24978/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24978
View PR using the GUI difftool:
$ git pr show -t 24978
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24978.diff
Using Webrev
Link to Webrev Comment