Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353659: SubmissionPublisherTest::testCap1Submit times out #24473

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Apr 6, 2025

This PR reverts the deactivation changes of the updates to FJP introduced in JDK-8319447.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353659: SubmissionPublisherTest::testCap1Submit times out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24473/head:pull/24473
$ git checkout pull/24473

Update a local copy of the PR:
$ git checkout pull/24473
$ git pull https://git.openjdk.org/jdk.git pull/24473/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24473

View PR using the GUI difftool:
$ git pr show -t 24473

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24473.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2025

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353659: SubmissionPublisherTest::testCap1Submit times out

Reviewed-by: dl, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 60fbf73: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
  • 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
  • 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
  • 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
  • 66435c2: 8352684: Opensource JInternalFrame tests - series1
  • 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
  • 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
  • e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
  • 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
  • c494a00: 8353559: Restructure CollectedHeap error printing
  • ... and 34 more: https://git.openjdk.org/jdk/compare/64b691ab619d2d99a9c6492341074d2794563c16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@viktorklang-ora
Copy link
Contributor Author

@AlanBateman @DougLea This is a draft PR for now. I need to run some additional tier-testing in order to promote to a "real" PR.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@viktorklang-ora viktorklang-ora marked this pull request as ready for review April 6, 2025 18:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2025

Webrevs

@viktorklang-ora
Copy link
Contributor Author

@AlanBateman @DougLea Testing-wise this is ready for review and, hopefully, integration.

Copy link
Contributor

@DougLea DougLea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for tracking this down.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
@viktorklang-ora
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit 4021033.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 60fbf73: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
  • 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
  • 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
  • 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
  • 66435c2: 8352684: Opensource JInternalFrame tests - series1
  • 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
  • 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
  • e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
  • 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
  • c494a00: 8353559: Restructure CollectedHeap error printing
  • ... and 34 more: https://git.openjdk.org/jdk/compare/64b691ab619d2d99a9c6492341074d2794563c16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@viktorklang-ora Pushed as commit 4021033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants