8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead #24468

linzihao1999 · 2025-04-05T14:26:13Z

Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET Lambda form. Instead of caching the entire LambdaForm, change it to store a SoftReference. This will avoid unnecessary memory usage.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead (Enhancement - P4)

Reviewers

Chen Liang (@liach - Reviewer)
Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24468/head:pull/24468
$ git checkout pull/24468

Update a local copy of the PR:
$ git checkout pull/24468
$ git pull https://git.openjdk.org/jdk.git pull/24468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24468

View PR using the GUI difftool:
$ git pr show -t 24468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24468.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-05T14:26:56Z

👋 Welcome back linzihao1999! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-05T14:27:44Z

@linzihao1999 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead

Reviewed-by: liach, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

799e5b3: 8354071: Add LintCategory property indicating whether @SuppressWarnings is supported
36e11b6: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method
0e223f1: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test
... and 115 more: https://git.openjdk.org/jdk/compare/9bb804b14e164982860db6323c7db33214cd0d36...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach, @JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-04-05T14:28:11Z

@linzihao1999 The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-05T14:30:58Z

Webrevs

01: Full - Incremental (3ce154ea)
00: Full (e70fb819)

liach · 2025-04-06T00:04:19Z

src/java.base/share/classes/java/lang/invoke/MethodTypeForm.java

@@ -64,6 +64,8 @@ final class MethodTypeForm {
    // Cached lambda form information, for basic types only:
    private final Object[] lambdaForms;

+    private SoftReference<MemberName> interpretEntry;
+
    // Indexes into lambdaForms:
    static final int
            LF_INVVIRTUAL              =  0,  // DMH invokeVirtual


You can remove the LF_INTERPRET constant from this list.

OK, removed it.

Now the index 6 is left unused in the LF cache array - we can leave it empty and renumber the cache indices when we add a new entry to cache.

Got it, thanks for the explanation.

liach · 2025-04-07T19:17:45Z

I shall run hs-tier2 before approving, in case mainline leyden doesn't work with WeakReferences.

liach · 2025-04-10T15:52:10Z

One unrelated client test failed in tier 1-3, everything else was fine.

linzihao1999 · 2025-04-10T15:58:12Z

/integrate

openjdk · 2025-04-10T15:59:44Z

@linzihao1999
Your change (at version 3ce154e) is now ready to be sponsored by a Committer.

JornVernee

Looks good to me. Nice simplification!

liach · 2025-04-10T17:21:22Z

Thanks!

/sponsor

openjdk · 2025-04-10T17:21:52Z

Going to push as commit dc249be.
Since your change was applied there have been 118 commits pushed to the master branch:

799e5b3: 8354071: Add LintCategory property indicating whether @SuppressWarnings is supported
36e11b6: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method
0e223f1: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test
... and 115 more: https://git.openjdk.org/jdk/compare/9bb804b14e164982860db6323c7db33214cd0d36...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-10T17:22:05Z

@liach @linzihao1999 Pushed as commit dc249be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

linzihao1999 added 2 commits April 1, 2025 23:32

8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead

720b545

Merge branch 'openjdk:master' into JDK-8350462

e70fb81

openjdk bot added the rfr Pull request is ready for review label Apr 5, 2025

openjdk bot added the core-libs [email protected] label Apr 5, 2025

liach reviewed Apr 6, 2025

View reviewed changes

remove LF_INTERPRET

3ce154e

linzihao1999 requested a review from liach April 6, 2025 12:55

liach approved these changes Apr 10, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 10, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 10, 2025

JornVernee approved these changes Apr 10, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Apr 10, 2025

openjdk bot closed this Apr 10, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 10, 2025

linzihao1999 deleted the JDK-8350462 branch April 10, 2025 17:29

graalvmbot mentioned this pull request Apr 23, 2025

[GR-64422] Update labsjdk to 25+19-jvmci-b01 oracle/graal#11071

Merged

8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead #24468

8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead #24468

Uh oh!

Conversation

linzihao1999 commented Apr 5, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 5, 2025

Uh oh!

openjdk bot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 5, 2025

Uh oh!

mlbridge bot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

liach Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

linzihao1999 Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

liach Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

linzihao1999 Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

liach commented Apr 7, 2025

Uh oh!

liach commented Apr 10, 2025

Uh oh!

linzihao1999 commented Apr 10, 2025

Uh oh!

openjdk bot commented Apr 10, 2025

Uh oh!

JornVernee left a comment

Choose a reason for hiding this comment

Uh oh!

liach commented Apr 10, 2025

Uh oh!

openjdk bot commented Apr 10, 2025

Uh oh!

openjdk bot commented Apr 10, 2025

Uh oh!

Uh oh!

linzihao1999 commented Apr 5, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 5, 2025 •

edited

Loading

mlbridge bot commented Apr 5, 2025 •

edited

Loading