Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead #24468

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

linzihao1999
Copy link
Contributor

@linzihao1999 linzihao1999 commented Apr 5, 2025

Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET Lambda form. Instead of caching the entire LambdaForm, change it to store a SoftReference. This will avoid unnecessary memory usage.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24468/head:pull/24468
$ git checkout pull/24468

Update a local copy of the PR:
$ git checkout pull/24468
$ git pull https://git.openjdk.org/jdk.git pull/24468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24468

View PR using the GUI difftool:
$ git pr show -t 24468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24468.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2025

👋 Welcome back linzihao1999! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2025
@openjdk
Copy link

openjdk bot commented Apr 5, 2025

@linzihao1999 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 5, 2025

Webrevs

@@ -64,6 +64,8 @@ final class MethodTypeForm {
// Cached lambda form information, for basic types only:
private final Object[] lambdaForms;

private SoftReference<MemberName> interpretEntry;

// Indexes into lambdaForms:
static final int
LF_INVVIRTUAL = 0, // DMH invokeVirtual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the LF_INTERPRET constant from this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the index 6 is left unused in the LF cache array - we can leave it empty and renumber the cache indices when we add a new entry to cache.

@linzihao1999 linzihao1999 requested a review from liach April 6, 2025 12:55
@liach
Copy link
Member

liach commented Apr 7, 2025

I shall run hs-tier2 before approving, in case mainline leyden doesn't work with WeakReferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants