-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead #24468
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back linzihao1999! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@linzihao1999 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@@ -64,6 +64,8 @@ final class MethodTypeForm { | |||
// Cached lambda form information, for basic types only: | |||
private final Object[] lambdaForms; | |||
|
|||
private SoftReference<MemberName> interpretEntry; | |||
|
|||
// Indexes into lambdaForms: | |||
static final int | |||
LF_INVVIRTUAL = 0, // DMH invokeVirtual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the LF_INTERPRET constant from this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the index 6 is left unused in the LF cache array - we can leave it empty and renumber the cache indices when we add a new entry to cache.
I shall run hs-tier2 before approving, in case mainline leyden doesn't work with WeakReferences. |
Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET Lambda form. Instead of caching the entire LambdaForm, change it to store a SoftReference. This will avoid unnecessary memory usage.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24468/head:pull/24468
$ git checkout pull/24468
Update a local copy of the PR:
$ git checkout pull/24468
$ git pull https://git.openjdk.org/jdk.git pull/24468/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24468
View PR using the GUI difftool:
$ git pr show -t 24468
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24468.diff
Using Webrev
Link to Webrev Comment