Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352686: Opensource JInternalFrame tests - series3 #24466

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 5, 2025

Few JInternalFrame tests are opensourced


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352686: Opensource JInternalFrame tests - series3 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24466/head:pull/24466
$ git checkout pull/24466

Update a local copy of the PR:
$ git checkout pull/24466
$ git pull https://git.openjdk.org/jdk.git pull/24466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24466

View PR using the GUI difftool:
$ git pr show -t 24466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24466.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2025

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352686: Opensource JInternalFrame tests - series3

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 254 new commits pushed to the master branch:

  • 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
  • 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
  • d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
  • d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
  • 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
  • 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
  • 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
  • 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
  • 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
  • 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
  • ... and 244 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2025
@openjdk
Copy link

openjdk bot commented Apr 5, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit 27c8d9d.
Since your change was applied there have been 260 commits pushed to the master branch:

  • 66435c2: 8352684: Opensource JInternalFrame tests - series1
  • 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
  • 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
  • e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
  • 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
  • c494a00: 8353559: Restructure CollectedHeap error printing
  • 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
  • 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
  • d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
  • d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
  • ... and 250 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@prsadhuk Pushed as commit 27c8d9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8352686 branch April 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants