Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353589: Open source a few Swing menu-related tests #24457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 4, 2025

Open source a few tests related to Swing menus.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353589: Open source a few Swing menu-related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24457/head:pull/24457
$ git checkout pull/24457

Update a local copy of the PR:
$ git checkout pull/24457
$ git pull https://git.openjdk.org/jdk.git pull/24457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24457

View PR using the GUI difftool:
$ git pr show -t 24457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24457.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@prrace This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title 8353589 8353589: Open source a few Swing menu-related tests Apr 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor inline comments.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants