Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353735: [JVMCI] Allow specifying storage kind of the callee save register #24451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Apr 4, 2025

Windows x64 ABI considers the upper portions of YMM0-YMM15 and ZMM0-ZMM15 volatile, that is, destroyed on function calls. This PR allows RegisterConfig implementations to refine the storage kind of callee save register, such that JVMCI compiler can exploit this information to avoid saving full width of these registers.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353735: [JVMCI] Allow specifying storage kind of the callee save register (New Feature - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24451/head:pull/24451
$ git checkout pull/24451

Update a local copy of the PR:
$ git checkout pull/24451
$ git pull https://git.openjdk.org/jdk.git pull/24451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24451

View PR using the GUI difftool:
$ git pr show -t 24451

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24451.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353735: [JVMCI] Allow specifying storage kind of the callee save register

Reviewed-by: dnsimon, cslucas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mur47x111 mur47x111 marked this pull request as ready for review April 7, 2025 14:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2025

Webrevs

@@ -94,6 +94,13 @@ default int getMaximumFrameSize() {
*/
RegisterArray getCalleeSaveRegisters();

/**
* Gets the storage kind for a callee save register.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a second sentence describing the Window ABI example so that it's clear why this API exists.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
Copy link
Contributor

@JohnTortugo JohnTortugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal [email protected] hotspot-compiler [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants