-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8353735: [JVMCI] Allow specifying storage kind of the callee save register #24451
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@@ -94,6 +94,13 @@ default int getMaximumFrameSize() { | |||
*/ | |||
RegisterArray getCalleeSaveRegisters(); | |||
|
|||
/** | |||
* Gets the storage kind for a callee save register. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a second sentence describing the Window ABI example so that it's clear why this API exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Windows x64 ABI considers the upper portions of YMM0-YMM15 and ZMM0-ZMM15 volatile, that is, destroyed on function calls. This PR allows
RegisterConfig
implementations to refine the storage kind of callee save register, such that JVMCI compiler can exploit this information to avoid saving full width of these registers.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24451/head:pull/24451
$ git checkout pull/24451
Update a local copy of the PR:
$ git checkout pull/24451
$ git pull https://git.openjdk.org/jdk.git pull/24451/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24451
View PR using the GUI difftool:
$ git pr show -t 24451
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24451.diff
Using Webrev
Link to Webrev Comment