8334391: JDK build should exclude *-files directories for Java source #24449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always exclude
doc-files
andsnippet-files
when compiling java code. To generalize this, exclude all*-files
directories.(The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, EXCLUDE_FILES prepends a
%
wildchar match to the filenames given, which we use here, while EXCLUDES matches only strict directory names in the path. These should probably be clarified/redesigned for more intuitive exclusion.)Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24449/head:pull/24449
$ git checkout pull/24449
Update a local copy of the PR:
$ git checkout pull/24449
$ git pull https://git.openjdk.org/jdk.git pull/24449/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24449
View PR using the GUI difftool:
$ git pr show -t 24449
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24449.diff