Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334391: JDK build should exclude *-files directories for Java source #24449

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 4, 2025

We should always exclude doc-files and snippet-files when compiling java code. To generalize this, exclude all *-files directories.

(The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, EXCLUDE_FILES prepends a % wildchar match to the filenames given, which we use here, while EXCLUDES matches only strict directory names in the path. These should probably be clarified/redesigned for more intuitive exclusion.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334391: JDK build should exclude *-files directories for Java source (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24449/head:pull/24449
$ git checkout pull/24449

Update a local copy of the PR:
$ git checkout pull/24449
$ git pull https://git.openjdk.org/jdk.git pull/24449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24449

View PR using the GUI difftool:
$ git pr show -t 24449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24449.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@magicus
Copy link
Member Author

magicus commented Apr 4, 2025

/label -core-libs

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus
The core-libs label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant