8356128: Correct documentation for --linux-package-deps

[StefanLobbenmeier]

The documentation suggests that --linux-package-deps is a boolean option, while in fact it is a string option with dependencies separated by comma and space

You can tell that this option is supposed to have an argument here:

jdk/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java

Lines 366 to 372 in fea5f2b

	private static final BundlerParamInfo<String> LINUX_PACKAGE_DEPENDENCIES =
	new StandardBundlerParam<>(
	Arguments.CLIOptions.LINUX_PACKAGE_DEPENDENCIES.getId(),
	String.class,
	params -> "",
	(s, p) -> s
	);

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356128: Correct documentation for --linux-package-deps (Bug - P4)

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23638/head:pull/23638
$ git checkout pull/23638

Update a local copy of the PR:
$ git checkout pull/23638
$ git pull https://git.openjdk.org/jdk.git pull/23638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23638

View PR using the GUI difftool:
$ git pr show -t 23638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23638.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @StefanLobbenmeier, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user StefanLobbenmeier" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@StefanLobbenmeier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356128: Correct documentation for --linux-package-deps

Reviewed-by: asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1713 new commits pushed to the master branch:

• 461cb84: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen
• c382da5: 8358178: Some nsk/jdi tests should be run with includevirtualthreads=y even though they pass without
• 44d62c8: 8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114
• ... and 1710 more: https://git.openjdk.org/jdk/compare/19c0ce43e258d00d77314d76a361feb2069a5af1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @sashamatveev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@StefanLobbenmeier The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[StefanLobbenmeier]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[StefanLobbenmeier]

See also JetBrains/compose-multiplatform#5227 for a discussion if this option has an argument

[bridgekeeper]

@StefanLobbenmeier This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[StefanLobbenmeier]

Just gonna try /signed again, but I didn’t get any more information from oracle

[bridgekeeper]

@StefanLobbenmeier This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[StefanLobbenmeier]

a new comment
I guess the action also suggests that i should first create a Jira issue

[StefanLobbenmeier]

Cannot do that, but I could create a but to oracle jdk so I used that review id

[mlbridge]

Webrevs

• 03: Full - Incremental (51ed08e2)
• 02: Full - Incremental (91831e7e)
• 01: Full - Incremental (062239e7)
• 00: Full (255015b9)

[StefanLobbenmeier]

Also maybe one follow up question - what do I need to do so the change appears in older versions like

• https://docs.oracle.com/en/java/javase/21/docs/specs/man/jpackage.html
• https://docs.oracle.com/en/java/javase/17/docs/specs/man/jpackage.html

[alexeysemenyukoracle]

Thank you for making the change! Other property files and jpackage.md should also be updated to sync them with HelpResources.properties.

[alexeysemenyukoracle]

Also maybe one follow up question - what do I need to do so the change appears in older versions like

You need to backport this fix once it is integrated. See https://openjdk.org/guide/#backporting

[StefanLobbenmeier]

Thank you for making the change! Other property files and jpackage.md should also be updated to sync them with HelpResources.properties.

Done, sorry I missed them

[alexeysemenyukoracle]

Looks good!

[alexeysemenyukoracle]

@StefanLobbenmeier, if you would like to have this fix in JDK25, you need to issue the /integrate command in the PR. I'll sponsor it. The entire sequence should be completed by the end of June 4th; otherwise, this fix will be included in JDK26.

[StefanLobbenmeier]

/integrate

[openjdk]

@StefanLobbenmeier This pull request has not yet been marked as ready for integration.

[StefanLobbenmeier]

There is an integration blocker because of the issue title, should I change the PR or can you change the issue title?

[alexeysemenyukoracle]

I've updated the title in the JBS record. Please try to integrate.

[StefanLobbenmeier]

/integrate

[openjdk]

@StefanLobbenmeier
Your change (at version 51ed08e) is now ready to be sponsored by a Committer.

[alexeysemenyukoracle]

/sponsor

[openjdk]

Going to push as commit cc11b7d.
Since your change was applied there have been 1715 commits pushed to the master branch:

• 406f1bc: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps
• e984fa7: 8358539: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
• 461cb84: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen
• ... and 1712 more: https://git.openjdk.org/jdk/compare/19c0ce43e258d00d77314d76a361feb2069a5af1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle @StefanLobbenmeier Pushed as commit cc11b7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[StefanLobbenmeier]

Thank you very much for sponsoring ❤️

[alexeysemenyukoracle]

No problem. Thank you for your contribution!