fix(glm52): gate kernels behind explicit feature#478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openinfer-glm52/glm52feature and make the kernels dependency optionalopeninfer-server/glm52into the model crate feature so GLM5.2 still opts intoopeninfer-kernels/glm52glm52submodule contractValidation
cargo tree --workspace -e features -i openinfer-kernelsshows noglm52/moefeature on the default workspace pathcargo tree -p openinfer-server --features glm52 -e features -i openinfer-kernelsshowsopeninfer-server/glm52 -> openinfer-glm52/glm52 -> openinfer-kernels/glm52 -> moecargo fmt --all --checkgit diff --checkcargo check --release --workspacecargo test --release -p openinfer-glm52 --libOPENINFER_NCCL_ROOT=/data/opt/nccl-2.30.4 cargo check --release -p openinfer-glm52 --features glm52OPENINFER_NCCL_ROOT=/data/opt/nccl-2.30.4 cargo check --release -p openinfer-server --features glm52OPENINFER_NCCL_ROOT=/data/opt/nccl-2.30.4 cargo test --release -p openinfer-glm52 --features glm52 --libOPENINFER_NCCL_ROOT=/data/opt/nccl-2.30.4Note:
cargo test --release --workspace --libcompiled and started the default workspace path withglm52/moedisabled, then failed on local GDR setup inopeninfer-comm-cuda-lib::test_gdr::gdr_copy_flag_GPU(Failed to create GDR copy handle).