-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet Attestation: Option with new request/response parameters #318
Open
c2bo
wants to merge
8
commits into
main
Choose a base branch
from
c2bo/wallet-attestation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d01ee02
add wallet attestation as new request/response parameters
c2bo eba9156
Merge branch 'main' into c2bo/wallet-attestation
c2bo abbe891
Apply suggestions from Giuseppe
c2bo 2a550b7
Merge branch 'main' into c2bo/wallet-attestation
c2bo 7371d6e
add vci reference for wallet attestation
c2bo ad8f2ec
Merge branch 'main' into c2bo/wallet-attestation
c2bo 6b91eb2
Apply suggestions from Daniel
c2bo 5b99be9
point to the correct appendix
c2bo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I want to find a solution but, sincerely, this appears very naif.
different trust frameworks may defines many different wallet attestations. By only requesting a "wallet attestation" (any of them, at least one) would end in a useless/weak parameter.
The RP needs to ask one or more (considering at least one of a set of supported one) wallet attestation.
For this reason, using presentation_definition or duckle appeared to me the best way to fully specify the wallet attestation, by type and properties.