Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breaking change alert for EspMilightHub #1463

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Add breaking change alert for EspMilightHub #1463

merged 2 commits into from
Dec 16, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 15, 2023

@ccutrer ccutrer mentioned this pull request Jan 15, 2023
Merged
@wborn wborn added the awaiting other PR Depends on another PR label Feb 18, 2023
wborn
wborn requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be moved to the right OH version when it gets merged.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label Dec 16, 2023
@lolodomo
Copy link
Contributor

@ccutrer : is there something else to change here ? Can you remove the draft status so that it can be merged ?

@ccutrer ccutrer force-pushed the espmilighthub-breaking-change branch from 414149f to c3bbcaf Compare December 16, 2023 18:35
@ccutrer ccutrer marked this pull request as ready for review December 16, 2023 18:35
@ccutrer ccutrer requested a review from a team as a code owner December 16, 2023 18:35
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 16, 2023

Rebased and put into the proper section. Ready to merge now.

@ccutrer
alphabetize alerts
6a7c791 
Signed-off-by: Cody Cutrer <[email protected]>
wborn
wborn approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 3721abe into openhab:main Dec 16, 2023
3 checks passed
@wborn wborn added this to the 4.1 milestone Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo left review comments

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ccutrer @lolodomo @wborn