Skip to content

update favicon to blue warship icon #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpelle merged 1 commit into from
Mar 5, 2026
Merged

update favicon to blue warship icon #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/>
<title data-i18n="main.title">OpenFront (ALPHA)</title>
<link rel="manifest" href="/manifest.json" />
<link rel="icon" type="image/x-icon" href="/images/Favicon.svg" />
<link rel="icon" type="image/svg+xml" href="/images/Favicon.svg" />
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find the favicon file in the repository
echo "=== Searching for Favicon.svg ==="
fd -t f "Favicon.svg"

echo ""
echo "=== Checking icon references in HTML files ==="
rg -n "rel=\"icon\"" --type html -C2

echo ""
echo "=== Checking /images/ path references ==="
rg -n "href=\"/images/" --type html

echo ""
echo "=== Checking /resources/ path references for icons ==="
rg -n "/resources/icons" --type html

Repository: openfrontio/OpenFrontIO

Length of output: 642

🏁 Script executed:

#!/bin/bash
echo "=== Checking lines around 130, 136, 143 for image paths ==="
cat -n src/client/index.html | sed -n '128,145p'

echo ""
echo "=== Checking all href paths in index.html ==="
rg -n "href=" src/client/index.html | head -20

Repository: openfrontio/OpenFrontIO

Length of output: 306

🏁 Script executed:

#!/bin/bash
echo "=== Finding index.html files ==="
fd -t f "index.html"

echo ""
echo "=== Checking repository structure ==="
git ls-files | grep -E "(index\.html|favicon)" | head -20

Repository: openfrontio/OpenFrontIO

Length of output: 254

🏁 Script executed:

#!/bin/bash
echo "=== Checking lines 1-20 to locate favicon ==="
head -n 20 index.html

echo ""
echo "=== Total lines in index.html ==="
wc -l index.html

echo ""
echo "=== Checking all image/icon href attributes ==="
rg -n "href=|src=" index.html | head -30

Repository: openfrontio/OpenFrontIO

Length of output: 1436

🏁 Script executed:

#!/bin/bash
echo "=== Searching for /resources/ path references in index.html ==="
rg -n "/resources/" index.html

echo ""
echo "=== Searching for image src or href patterns ==="
rg -n "(src=|href=).*\.(png|jpg|jpeg|svg|gif|webp)" index.html

echo ""
echo "=== Checking entire index.html for static asset paths ==="
rg -n "/(images|resources|assets|static)/" index.html

Repository: openfrontio/OpenFrontIO

Length of output: 945

Change favicon path to match other image resources.

Line 11 uses /images/Favicon.svg, but the file is at resources/images/Favicon.svg. Other images in the same file (lines 130, 136, 143) correctly use /resources/images/. Update the favicon href to /resources/images/Favicon.svg.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@index.html` at line 11, Update the favicon link href so it points to the same
images directory used elsewhere: change the <link rel="icon" ... href> value
from "/images/Favicon.svg" to "/resources/images/Favicon.svg" (update the href
attribute in the link tag that defines the favicon).


<!-- Preload styles -->
<style>
Expand Down
Binary file removed resources/images/Favicon.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion resources/images/Favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading