Conversation
Added dyslexdria " World "
Added dyslexdria " World "
WalkthroughThis PR introduces a new game map named "Dyslexdria" by adding nation data assets, a map manifest with scaled variants and nation metadata, a game enum member for the map type, and a localization entry for the map name. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
map-generator/assets/maps/dyslexdria/info.json (1)
74-78: Inconsistent indentation on two entries.Lines 74 and 194 have non-standard leading whitespace compared to the rest of the array (4-space indent). Minor cosmetic issue.
✏️ Proposed fix
- { + { "coordinates": [1370, 670], "flag": "ae", "name": "United Bara Estimates" },- { + { "coordinates": [1950, 1305], "flag": "aq", "name": "Nort Pole" },Also applies to: 194-198
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@map-generator/assets/maps/dyslexdria/info.json` around lines 74 - 78, Two array entries have inconsistent leading whitespace; locate the JSON objects with "name": "United Bara Estimates" (coordinates [1370, 670], flag "ae") and the other entry referenced in the comment (lines ~194-198) and normalize their indentation to match the rest of the array (use 4-space indentation for the object opening line and its properties) so the file's formatting is consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/lang/en.json`:
- Line 329: The translation entry "dyslexdria" currently has leading/trailing
spaces (" World ") which will render visible whitespace; remove the surrounding
spaces so the display string is "World" and ensure any uniqueness/joke is
handled on the enum value (see Game.ts around the enum at line ~120) rather than
by injecting whitespace into the user-facing string; update the "dyslexdria"
value only (and adjust the enum value in Game.ts if needed) so UI displays
"World" cleanly.
---
Nitpick comments:
In `@map-generator/assets/maps/dyslexdria/info.json`:
- Around line 74-78: Two array entries have inconsistent leading whitespace;
locate the JSON objects with "name": "United Bara Estimates" (coordinates [1370,
670], flag "ae") and the other entry referenced in the comment (lines ~194-198)
and normalize their indentation to match the rest of the array (use 4-space
indentation for the object opening line and its properties) so the file's
formatting is consistent.
| "surrounded": "Surrounded", | ||
| "didier": "Didier", | ||
| "didierfrance": "Didier (France)", | ||
| "dyslexdria": " World ", |
There was a problem hiding this comment.
Display value " World " with surrounding spaces will render with visible whitespace in the map selector.
Every other map entry has a clean display string. The leading/trailing spaces here will appear as extra padding around the map name in the UI, which reads as a rendering bug. If the intent is to call it "World" (to create the joke), the unique disambiguation should live at the enum-value level (see the comment on Game.ts line 120), not by injecting whitespace into the user-visible display string.
💡 Proposed fix (after fixing the enum value)
- "dyslexdria": " World ",
+ "dyslexdria": "World",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dyslexdria": " World ", | |
| "dyslexdria": "World", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@resources/lang/en.json` at line 329, The translation entry "dyslexdria"
currently has leading/trailing spaces (" World ") which will render visible
whitespace; remove the surrounding spaces so the display string is "World" and
ensure any uniqueness/joke is handled on the enum value (see Game.ts around the
enum at line ~120) rather than by injecting whitespace into the user-facing
string; update the "dyslexdria" value only (and adjust the enum value in Game.ts
if needed) so UI displays "World" cleanly.
|
@patrickbadly-hub would you please include a photo of the map? |
Description: Submission of working map Dyslexdria.
Describe the PR.
-Pre edited map source is the high res world map provided in the MapGenerator files.
Please put your Discord username so you can be contacted if a bug or regression is found:
PlaysBadly
I've never done a pull request before, so feel free to check my work. This was tested on a local server using an up to date copy of the local git. I then manually updated my forked repository.