Skip to content

Comments

Add Map - Dyslexdria#3282

Open
patrickbadly-hub wants to merge 11 commits intoopenfrontio:mainfrom
patrickbadly-hub:main
Open

Add Map - Dyslexdria#3282
patrickbadly-hub wants to merge 11 commits intoopenfrontio:mainfrom
patrickbadly-hub:main

Conversation

@patrickbadly-hub
Copy link

Description: Submission of working map Dyslexdria.

Describe the PR.

  • en.json and game.ts updated. Listed in game as " World " as first public use is desired to be on April Fools Day. Titled " World " to prevent conflict with "World". Set to Solo play only. Listed under Other maps with regular World thumbnail.
  • Map files uploaded to map-generator and resources folders.
    -Pre edited map source is the high res world map provided in the MapGenerator files.

Please put your Discord username so you can be contacted if a bug or regression is found:

PlaysBadly

I've never done a pull request before, so feel free to check my work. This was tested on a local server using an up to date copy of the local git. I then manually updated my forked repository.

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Walkthrough

This PR introduces a new game map named "Dyslexdria" by adding nation data assets, a map manifest with scaled variants and nation metadata, a game enum member for the map type, and a localization entry for the map name.

Changes

Cohort / File(s) Summary
Map Assets
map-generator/assets/maps/dyslexdria/info.json, resources/maps/dyslexdria/manifest.json
New map definition files containing nation data with coordinates, flags, and names; manifest includes scaled map variants (map, map16x, map4x) with dimensions and tile counts.
Game Integration
src/core/game/Game.ts
Added Dyslexdria enum member to GameMapType and registered it in the mapCategories.fantasy array.
Localization
resources/lang/en.json
Added translation key dyslexdria under the map section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🗺️ A world of wonder takes its shape,
With nations drawn in colorful escape,
Dyslexdria joins the fantasy fold,
A map with stories waiting to be told! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Map - Dyslexdria' directly and clearly describes the main change: adding a new map named Dyslexdria.
Description check ✅ Passed The description explains the map submission, mentions updates to en.json and Game.ts, references map file uploads, and provides testing details relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
map-generator/assets/maps/dyslexdria/info.json (1)

74-78: Inconsistent indentation on two entries.

Lines 74 and 194 have non-standard leading whitespace compared to the rest of the array (4-space indent). Minor cosmetic issue.

✏️ Proposed fix
-        {
+    {
       "coordinates": [1370, 670],
       "flag": "ae",
       "name": "United Bara Estimates"
     },
- {
+    {
       "coordinates": [1950, 1305],
       "flag": "aq",
       "name": "Nort Pole"
     },

Also applies to: 194-198

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@map-generator/assets/maps/dyslexdria/info.json` around lines 74 - 78, Two
array entries have inconsistent leading whitespace; locate the JSON objects with
"name": "United Bara Estimates" (coordinates [1370, 670], flag "ae") and the
other entry referenced in the comment (lines ~194-198) and normalize their
indentation to match the rest of the array (use 4-space indentation for the
object opening line and its properties) so the file's formatting is consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/lang/en.json`:
- Line 329: The translation entry "dyslexdria" currently has leading/trailing
spaces (" World ") which will render visible whitespace; remove the surrounding
spaces so the display string is "World" and ensure any uniqueness/joke is
handled on the enum value (see Game.ts around the enum at line ~120) rather than
by injecting whitespace into the user-facing string; update the "dyslexdria"
value only (and adjust the enum value in Game.ts if needed) so UI displays
"World" cleanly.

---

Nitpick comments:
In `@map-generator/assets/maps/dyslexdria/info.json`:
- Around line 74-78: Two array entries have inconsistent leading whitespace;
locate the JSON objects with "name": "United Bara Estimates" (coordinates [1370,
670], flag "ae") and the other entry referenced in the comment (lines ~194-198)
and normalize their indentation to match the rest of the array (use 4-space
indentation for the object opening line and its properties) so the file's
formatting is consistent.

"surrounded": "Surrounded",
"didier": "Didier",
"didierfrance": "Didier (France)",
"dyslexdria": " World ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Display value " World " with surrounding spaces will render with visible whitespace in the map selector.

Every other map entry has a clean display string. The leading/trailing spaces here will appear as extra padding around the map name in the UI, which reads as a rendering bug. If the intent is to call it "World" (to create the joke), the unique disambiguation should live at the enum-value level (see the comment on Game.ts line 120), not by injecting whitespace into the user-visible display string.

💡 Proposed fix (after fixing the enum value)
-    "dyslexdria": " World ",
+    "dyslexdria": "World",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"dyslexdria": " World ",
"dyslexdria": "World",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/lang/en.json` at line 329, The translation entry "dyslexdria"
currently has leading/trailing spaces (" World ") which will render visible
whitespace; remove the surrounding spaces so the display string is "World" and
ensure any uniqueness/joke is handled on the enum value (see Game.ts around the
enum at line ~120) rather than by injecting whitespace into the user-facing
string; update the "dyslexdria" value only (and adjust the enum value in Game.ts
if needed) so UI displays "World" cleanly.

@github-project-automation github-project-automation bot moved this from Triage to Development in OpenFront Release Management Feb 23, 2026
@iiamlewis
Copy link
Contributor

@patrickbadly-hub would you please include a photo of the map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

3 participants